Changes to portainer-compose.#17
Closed
JoshCodeAligator wants to merge 1 commit intogrowlf:ensf400_w24from
Closed
Conversation
Collaborator
|
Pull requests should contain useful information about the reasoning behind the changes for the repository maintainer to enable them to prioritize PRs. This is part of the collaborative workflow. |
growlf
reviewed
Feb 25, 2024
Owner
There was a problem hiding this comment.
These type of files are generated bt Mac systems and should not be included in the project. Please use the .ignore* files to prevent this in the future.
growlf
reviewed
Feb 25, 2024
Owner
There was a problem hiding this comment.
This would fail immediately as there is nothing that can respond on port 8000 when this stack fire up. Nice health check, definition if there was though.
Owner
|
This change request does not seem to have value or purpose towards the intent of this project. Please feel free to add and resubmit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12