The readme for Grpc.Net.Client.Web mentions GrpcWebHandler.HttpVersion as an available configuration option, however that property has been marked as obsolete in favor of GrpcChannelOptions.HttpVersion and GrpcChannelOptions.HttpVersionPolicy.
It seems to me like this property either shouldn't be called out, or the properties on GrpcChannelOptions should be mentioned. The latter seems more informative.
I'd be happy to open a PR to change this, just let met know which option is preferred.
|
* **HttpVersion**: HTTP protocol `Version` used to set [`HttpRequestMessage.Version`](https://docs.microsoft.com/dotnet/api/system.net.http.httprequestmessage.version#system-net-http-httprequestmessage-version) on the underlying gRPC HTTP request. gRPC-Web doesn't require a specific version and doesn't override the default unless specified. |
|
#if NET5_0_OR_GREATER |
|
[Obsolete("HttpVersion is obsolete and will be removed in a future release. Use GrpcChannelOptions.HttpVersion and GrpcChannelOptions.HttpVersionPolicy instead.")] |
|
#else |
|
[Obsolete("HttpVersion is obsolete and will be removed in a future release. Use GrpcChannelOptions.HttpVersion instead.")] |
|
#endif |
|
public Version? HttpVersion { get; set; } |
The readme for
Grpc.Net.Client.WebmentionsGrpcWebHandler.HttpVersionas an available configuration option, however that property has been marked as obsolete in favor ofGrpcChannelOptions.HttpVersionandGrpcChannelOptions.HttpVersionPolicy.It seems to me like this property either shouldn't be called out, or the properties on
GrpcChannelOptionsshould be mentioned. The latter seems more informative.I'd be happy to open a PR to change this, just let met know which option is preferred.
grpc-dotnet/src/Grpc.Net.Client.Web/README.md
Line 32 in d170b24
grpc-dotnet/src/Grpc.Net.Client.Web/GrpcWebHandler.cs
Lines 47 to 52 in d170b24