Skip to content

Obsolete property mentioned in Grpc.Net.Client.Web Readme #2630

@KnapSac

Description

@KnapSac

The readme for Grpc.Net.Client.Web mentions GrpcWebHandler.HttpVersion as an available configuration option, however that property has been marked as obsolete in favor of GrpcChannelOptions.HttpVersion and GrpcChannelOptions.HttpVersionPolicy.

It seems to me like this property either shouldn't be called out, or the properties on GrpcChannelOptions should be mentioned. The latter seems more informative.

I'd be happy to open a PR to change this, just let met know which option is preferred.

* **HttpVersion**: HTTP protocol `Version` used to set [`HttpRequestMessage.Version`](https://docs.microsoft.com/dotnet/api/system.net.http.httprequestmessage.version#system-net-http-httprequestmessage-version) on the underlying gRPC HTTP request. gRPC-Web doesn't require a specific version and doesn't override the default unless specified.

#if NET5_0_OR_GREATER
[Obsolete("HttpVersion is obsolete and will be removed in a future release. Use GrpcChannelOptions.HttpVersion and GrpcChannelOptions.HttpVersionPolicy instead.")]
#else
[Obsolete("HttpVersion is obsolete and will be removed in a future release. Use GrpcChannelOptions.HttpVersion instead.")]
#endif
public Version? HttpVersion { get; set; }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions