use an attribute from resolved addresses IS_PETIOLE_POLICY to control whether or not health checking is supported #11513
Conversation
… whether or not health checking is supported so that top level versions can't do any health checking, while those under petiole policies can. Fixes grpc#11413
|
The health checking does not need this flag, iirc. |
YifeiZhuang
left a comment
YifeiZhuang
left a comment
There was a problem hiding this comment.
It looks this is still needed.
| } | ||
| if (subchannelData.getHealthState() == READY) { | ||
|
|
||
| if (notAPetiolePolicy || subchannelData.getHealthState() == READY) { |
There was a problem hiding this comment.
You can just always set health status to READY when creating the subchannel. Same as L454.
There was a problem hiding this comment.
I've updated the if at line 453 to use notAPetiolePolicy for auto setting as ready, but I'd like to leave this here to make it clear to people maintaining the code what is happening since understanding that somewhere else set the value to READY and nowhere else should have changed it is difficult.
| public void onSubchannelState(ConnectivityStateInfo newState) { | ||
| if (notAPetiolePolicy) { | ||
| log.log(Level.WARNING, | ||
| "Ignoring health status {0} for subchannel {1} as this is not a petiole policy", |
There was a problem hiding this comment.
should we say "not a petiole policy" or "there is no petiole policy". This policy is always leaf policy, the difference is whether there is a petiole policy or this is top level policy. Health check can not be used with health producer + pick first (without petiole policy).
A61:
This set of policies, which we will refer to as "petiole" policies, includes the following:
round_robin (see gRPC Load Balancing)
weighted_round_robin (see gRFC A58)
ring_hash (see gRFC A42)
least_request (see gRFC A48 -- currently supported in Java and Go only)
There was a problem hiding this comment.
Updated message to say "not under a petiole policy"
…et health state to READY when creating the subchannel for notAPetiolePolicy.
2 participants
This blocks top level versions from doing any health checking, while those under petiole policies can.
Fixes #11413