Skip to content

Conversation

@shivaspeaks
Copy link
Member

No description provided.

@shivaspeaks shivaspeaks requested review from ejona86 and kannanjgithub and removed request for ejona86 September 18, 2024 07:17
@shivaspeaks shivaspeaks requested a review from ejona86 September 18, 2024 11:45
@ejona86 ejona86 changed the base branch from release-v1.67.0 to v1.67.x September 18, 2024 14:38
@ejona86
Copy link
Member

ejona86 commented Sep 18, 2024

The "base" for this PR should be v1.67.x, not the random branch "release-v1.67.0". I changed the base and that seems to have resolved the file conflicts.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: DO NOT MERGE FROM GITHUB. Follow the documented release steps.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 18, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Sep 18, 2024
@ejona86
Copy link
Member

ejona86 commented Sep 18, 2024

The CI wasn't running, so I "kicked it" with the kokoro:run label. The event to Kokoro was probably lost. Which label didn't actually matter, as it just fires a new event for Kokoro to consider running the CI.

@shivaspeaks shivaspeaks merged commit a475cfa into grpc:v1.67.x Sep 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants