Skip to content

Ensure hostname is ascii #11746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZachChuba wants to merge 1 commit into from
Closed

Ensure hostname is ascii #11746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/OkHostnameVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ private OkHostnameVerifier() {

@Override
public boolean verify(String host, SSLSession session) {
if (!isAscii(host)) {
return false;
}
try {
Certificate[] certificates = session.getPeerCertificates();
return verify(host, (X509Certificate) certificates[0]);
Expand Down Expand Up @@ -254,4 +257,13 @@ private boolean verifyHostName(String hostName, String pattern) {
// hostName matches pattern
return true;
}

private static boolean isAscii(String input) {
try {
// All only ascii characters are 1 byte in utf8
return input.getBytes("UTF-8").length == input.length();
} catch (java.io.UnsupportedEncodingException e) {
return false;
}
}
}