examples: Add XDS client example#6631
Conversation
|
@dapengzhang0, PTAL |
| 1. The server does not use XDS, so recent releases work fine. Building using | ||
| recent releases is much easier, so check out the most recent release tag: | ||
| ``` | ||
| $ git checkout v1.27.0 |
There was a problem hiding this comment.
This number and below will be changed after every release. Add a line of instruction at https://github.com/grpc/grpc-java/pull/6631/files#diff-60cd2f42437b5cb3c2c09391a6f4c54aR125 ?
There was a problem hiding this comment.
If you look at the history of https://github.com/grpc/grpc-java/commits/master/documentation/android-channel-builder.md, we miss a commit "Update README etc to reference 1.27.0", but RELEASING.md doesn't document to add this commit in the master branch, while similar commits were added for the past releases. I'm confused.
There was a problem hiding this comment.
As far as I'm concerned, I'm okay if we don't update this. Two reasons: 1) it'll work fine, no big deal. 2) grpc-xds should be published the next release or the release after, so it will only be "wrong" for a maximum of one release. Once grpc-xds is published this will be rewritten to look like the other examples and just say "use the latest tag"
2 participants
This depends on #6630, and includes a commit from it.