Skip to content

all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final #8780

Merged
sanjaypujare merged 4 commits intogrpc:masterfrom
sanjaypujare:netty-upgrade-4.1.72.final
Jan 7, 2022
Merged

all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final #8780
sanjaypujare merged 4 commits intogrpc:masterfrom
sanjaypujare:netty-upgrade-4.1.72.final

Conversation

@sanjaypujare
Copy link
Copy Markdown
Contributor

@sanjaypujare sanjaypujare commented Dec 22, 2021

fixes #8617

@sanjaypujare
Copy link
Copy Markdown
Contributor Author

sanjaypujare commented Dec 22, 2021

Closing as there are test failures...

@sanjaypujare sanjaypujare reopened this Dec 22, 2021
@sergiitk
Copy link
Copy Markdown
Member

sergiitk commented Dec 22, 2021

Also fixes #8781.

@sergiitk sergiitk mentioned this pull request Dec 22, 2021
Closed
@dapengzhang0
Copy link
Copy Markdown
Contributor

dapengzhang0 commented Dec 22, 2021

Normally there are also bazel and markdown files that need to be changed accordingly. Seem #8167 for example.

@sanjaypujare
xds: fix Executor.execute to actually run the Runnable passed. Becaus…
2613ed1 
…e of the netty fix to actually use

the executor passed to the SslHandler we now need the Executor to execute.
@sanjaypujare
Copy link
Copy Markdown
Contributor Author

sanjaypujare commented Dec 23, 2021

Normally there are also bazel and markdown files that need to be changed accordingly. Seem #8167 for example.

Done. PTAL

@sanjaypujare sanjaypujare added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Dec 23, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Dec 23, 2021
@dapengzhang0 dapengzhang0 changed the title xds: update netty to 4.1.72.Final and tcnative to 2.0.46.Final all: update netty to 4.1.72.Final and tcnative to 2.0.46.Final Dec 23, 2021
@sanjaypujare sanjaypujare force-pushed the netty-upgrade-4.1.72.final branch from 7b76d3e to 9638034 Compare December 29, 2021 06:18
@sanjaypujare
Copy link
Copy Markdown
Contributor Author

sanjaypujare commented Dec 29, 2021

@sergiitk as discussed offline. Tests now should be passing.

sergiitk
sergiitk reviewed Dec 30, 2021
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/ProtocolNegotiatorsTest.java Outdated
sergiitk
sergiitk reviewed Dec 30, 2021
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/NettyTestUtil.java
@sanjaypujare
Copy link
Copy Markdown
Contributor Author

sanjaypujare commented Dec 30, 2021

@dapengzhang0 just a reminder for the review. Also CC @ejona86

@sanjaypujare sanjaypujare force-pushed the netty-upgrade-4.1.72.final branch from b029530 to ee10b7a Compare December 30, 2021 23:34
sergiitk
sergiitk reviewed Dec 31, 2021
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/ProtocolNegotiatorsTest.java Outdated
dapengzhang0
dapengzhang0 reviewed Jan 4, 2022
View reviewed changes
Comment thread netty/src/test/java/io/grpc/netty/ProtocolNegotiatorsTest.java Outdated
@dapengzhang0
Copy link
Copy Markdown
Contributor

dapengzhang0 commented Jan 6, 2022

FYI @sanjaypujare ,

I merged #8801 , so now you can download the failed test report as shown in the picture to see the full Standard error by opening the index.html file in the browser.

@sanjaypujare
Copy link
Copy Markdown
Contributor Author

sanjaypujare commented Jan 6, 2022

FYI @sanjaypujare ,

I merged #8801 , so now you can download the failed test report as shown in the picture to see the full Standard error by opening the index.html file in the browser.

Thanks @dapengzhang0 ! Will do

This was referenced Jan 6, 2022
Closed
Closed
@sanjaypujare sanjaypujare force-pushed the netty-upgrade-4.1.72.final branch from cccbcda to 13cef28 Compare January 7, 2022 22:46
sergiitk
sergiitk approved these changes Jan 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

Comment thread buildscripts/kokoro/macos.cfg
@sanjaypujare sanjaypujare merged commit d7f951a into grpc:master Jan 7, 2022
@sanjaypujare sanjaypujare deleted the netty-upgrade-4.1.72.final branch January 7, 2022 23:35
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

+1 more reviewer

@dapengzhang0 dapengzhang0 dapengzhang0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need compatible versions for Netty 4.1.68+ , GRPC server and netty-tcnative-boringssl-static

5 participants

@sanjaypujare @sergiitk @dapengzhang0 @ejona86 @grpc-kokoro