bazel: Support maven_install's strict_visibility=True #9300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a poorly thought-out feature for maven_install in a world where the dependency list is being combined from multiple repositories, as it means all Bazel-aware dependencies must subscribe to the idea this is good and useful. It also loses effectiveness as transitive dependencies are likely to be included directly in maven_install; users of gRPC can use netty, guava, and other dependencies without explicitly defining them even with strict_visibility=True. Given maven_install still complains about "Found duplicate artifact versions", it isn't too surprising it doesn't make sense in a multi-repo world. This isn't a bad feature for gRPC as we are pretty low-level and it can be helpful when making bazel dependency versions match gradle dependency versions. But it doesn't necessarily seem like something we need to be too worried about making sure we use. Similarly, don't use it in the example as it seems low-value for our users. Fixes grpc#9288
sergiitk
approved these changes
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a poorly thought-out feature for maven_install in a
world where the dependency list is being combined from multiple
repositories, as it means all Bazel-aware dependencies must subscribe to
the idea this is good and useful. It also loses effectiveness as
transitive dependencies are likely to be included directly in
maven_install; users of gRPC can use netty, guava, and other
dependencies without explicitly defining them even with
strict_visibility=True. Given maven_install still complains
about "Found duplicate artifact versions", it isn't too surprising it
doesn't make sense in a multi-repo world.
This isn't a bad feature for gRPC as we are pretty low-level and it can
be helpful when making bazel dependency versions match gradle dependency
versions. But it doesn't necessarily seem like something we need to be
too worried about making sure we use. Similarly, don't use it in the
example as it seems low-value for our users.
Fixes #9288
CC @BoleynSu