Add UNIMPLEMENTED details when an RPC method is not impl.#207
Merged
murgatroid99 merged 1 commit intogrpc:masterfrom Mar 14, 2018
theogravity:master
Merged
Add UNIMPLEMENTED details when an RPC method is not impl.#207murgatroid99 merged 1 commit intogrpc:masterfrom theogravity:master
murgatroid99 merged 1 commit intogrpc:masterfrom
theogravity:master
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Contributor
Author
|
CLA signed. |
murgatroid99
approved these changes
Mar 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a situation where a test GRPC client was sending to a RPC method that did not yet exist on our GRPC server, resulting in an unclear error from the GRPC server:
It was a bit difficult to debug as the testing client was sending multiple events - this PR adds some clarification to which RPC method was being called that was not implemented.
With the update, we would now get clarification: