Update terraform-fmt to match terraform-validate#46
Merged
Conversation
This PR updates the `terraform-fmt` hook as follows: 1. Extract all the directories with Terraform code first and run `terraform fmt` once per directory. 1. Print out the directory where we're running `terraform fmt` to make debugging errors much easier. 1. Instead of exiting on the first error, save the exit codes, and print out all `fmt` errors before exiting. These changes are very similar to #45.
davidalger
reviewed
Dec 9, 2020
Co-authored-by: David Alger <davidmalger@gmail.com>
Member
Author
|
Seems to work great! PR updated. |
davidalger
approved these changes
Dec 10, 2020
Member
Author
|
Thanks for the review! Merging now. |
Member
Author
|
What was the reason for adding |
I second this as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
terraform-fmthook as follows:-diff -checkso the differences are printed, rather than made on disk.fmterrors before exiting.These changes are very similar to #45.