Added try/catch to avoid errors when cookies/storage is disabled#63
Closed
mrkoreye wants to merge 1 commit intogsklee:masterfrom
Closed
Added try/catch to avoid errors when cookies/storage is disabled#63mrkoreye wants to merge 1 commit intogsklee:masterfrom
mrkoreye wants to merge 1 commit intogsklee:masterfrom
Conversation
Contributor
|
This check is in place now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to bootstrap the angular app with cookies/storage turned off,
var webStorage = $window[storageType]was throwing an error. This caused the Angular app to fail bootstrap/init. This is similar to pull request 59 (#59), but adds a shimwebStorageobject. It also adds a check for an error that I got in Firefox wherewebStorage = $window['sessionStorage']evaluated, but then callingwebStorage.lengththrew a 'security' error.Thank you for making ngStorage!