Context and need-context message bindings #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the gst-plugins-base native project.
Member
|
Thanks! Will review ASAP. |
neilcsmith-net
requested changes
Nov 4, 2019
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
Please have a look at Element::getContext. Should definitely not be using initializer here, and it's probably leaking memory.
The only other change would probably be in mapping of Structure, but that needs some more looking at - happy to merge without changes there.
neilcsmith-net
approved these changes
Nov 5, 2019
Member
|
Thanks, squashing and merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to listen to need-context messages and to answer back by setting a context. Open the way to OpenGL support.