Support setting and getting GstObject properties as serialized String #190
Conversation
…t/get and GstObject setAsString/getAsString.
|
Had concerns this didn't address #166 but looks like an upstream bug that doesn't allow |
MaZderMind
left a comment
MaZderMind
left a comment
There was a problem hiding this comment.
Approve, although I'd like to see the free logic in finally blocks and would like to change/add to the tests.
Add test for GstValueArray from String Fix invalid enum test to use setAsString Add invalid enum as int test
…x property not available)
| assertTrue(matrix.contains("0.4")); | ||
| assertTrue(matrix.contains("0.6")); | ||
| assertTrue(matrix.contains("0.8")); | ||
| convert.dispose(); |
There was a problem hiding this comment.
The other Elements are creared in @before and not disposed explicitly. We should adjust them to use a similar pattern.
There was a problem hiding this comment.
I'm alright with the mix at the moment, as this element is only needed within that one test. Explicit disposal is generally preferred - in many respects I wish the bindings didn't support implicit collection, but we are where we are! Will keep at the moment, but relook later - tests need some love in general.
|
|
||
| @Test | ||
| public void setValueArrayFromString() { | ||
| if (!Gst.testVersion(1, 14)) { |
There was a problem hiding this comment.
Event with GStreamer 1.16 installed, this will never be true, becuase the actual version is limited to the requested version on Gst.init which in this Test is not specified and therefore defaults to Version.BASELINE which is only 1.8.0; so this Test will never be true, even when a more modern GStreamer is installed.
There was a problem hiding this comment.
Damn! Yes, thanks, forgot to change the init line - in general tests should be using the pattern from https://github.com/gstreamer-java/gst1-java-core/blob/master/test/org/freedesktop/gstreamer/PromiseTest.java#L37
There was a problem hiding this comment.
Actually the String-Array-Initialization in the linked Init-Call is unnecessary; Gst.init(Gst.getVersion(), "PromiseTest"); resolves to the same Constructor.
These are the Things that IntelliJ suggests. You might want to use a better IDE ;) :P (just kidding.)
There was a problem hiding this comment.
😆 Yes, I didn't write that one - sure the author was probably using Eclipse! 😉
Key thing is use of Gst.getVersion() in future.
There was a problem hiding this comment.
I opened #191 fixing the things discussed here.
2 participants
This supports setting and getting GstObject properties in a serialized String format. It makes use of
gst_value_serializeandgst_value_deserialize. This is in GstObject rather than GObject because it relies on GStreamer-specific functionality (with possible thought of splitting off GLib support in future).This code is intended as an alternative to #187 and includes an adapted version of the test by @MaZderMind in there. It fixes #182 as well as hopefully other uses mentioned in #166 and elsewhere.
Returned String representation of enums is surprising, but also usable in setAsString.