Skip to content

use and correctly handle PadProbeReturn.REMOVE #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neilcsmith-net merged 1 commit into from
Apr 13, 2020
Merged

use and correctly handle PadProbeReturn.REMOVE #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/org/freedesktop/gstreamer/Pad.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ public void block(final Runnable callback) {
public PadProbeReturn eventReceived(Pad pad, Event event) {
callback.run();
pad.removeCallback(EVENT_PROBE.class, this);
return PadProbeReturn.DROP;
return PadProbeReturn.REMOVE;
}
}, GstPadAPI.GST_PAD_PROBE_TYPE_BLOCKING | GstPadAPI.GST_PAD_PROBE_TYPE_EVENT_DOWNSTREAM);
}
Expand Down Expand Up @@ -404,7 +404,14 @@ public PadProbeReturn callback(Pad pad, GstPadProbeInfo probeInfo, Pointer user_
}
};

GCallback cb = new GCallback(handle.addProbe(mask, probe), probe) {
NativeLong id = handle.addProbe(mask, probe);
if (id.longValue() == 0) {
// the Probe was an IDLE-Probe and it was already handled synchronously in handle.addProbe,
// so no Callback needs to be registered
return;
}

GCallback cb = new GCallback(id, probe) {
@Override
protected void disconnect() {
handle.removeProbe(id);
Expand Down