avoid deadlock by synchronizing on addEventProbe #196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So based on this simple Gist I was able to trace a Deadlock within the
block-Call, where the Main and one of the GstBus-Threads seem to deadlock upon callingsynchronizedmethods withinPadandPad.Handle. I'm not yet sure how the respective calling paths are and which action results in the deadlock, but it is very quickly (wihin a couple of seconds) reproducible with the 1.1.0 release.Thread Info:
This can be mitigated ba synchronizing on
addEventProbe, as it is already done inaddDataProbeThis fix is part of a set of fixes for #184 and is extracted from #186