feat: Default to u32 when maximum is unset#1416
Merged
Conversation
Few object-store parameters set the format int64 and minimum to 0. Latest changes in the format handling result in u32 params in the generated code. Change the login to default at u32 when format is not specified, but u64 when int64 with min is specified. Additionally improve mentioned object-store schemas. Change-Id: I99f70526f2015beefe43950330b27c564688a69f Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com> Changes are triggered by https://review.opendev.org/960413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few object-store parameters set the format int64 and minimum to 0.
Latest changes in the format handling result in u32 params in the
generated code. Change the login to default at u32 when format is not
specified, but u64 when int64 with min is specified. Additionally
improve mentioned object-store schemas.
Change-Id: I99f70526f2015beefe43950330b27c564688a69f
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com
Changes are triggered by https://review.opendev.org/960413