refactor: Simplify parse_key_val_opt and parse_key_val#1425
Merged
gtema merged 1 commit intogtema:mainfrom Sep 21, 2025
Merged
Conversation
wilful
force-pushed
the
feature/use_split_once
branch
2 times, most recently
from
14c2c3c to
c45090d
Compare
wilful
changed the title
wilful
force-pushed
the
feature/use_split_once
branch
from
489cf26 to
2b7fcac
Compare
Contributor
Author
|
@gtema Привет, что-то я не могу понять что от меня еще требуется тут. Помоги |
Owner
|
@wilful: please use english to communicate here - this is an international project. On the first sight the change is ok, I just do not really think such change brings much improvement. Under the hood the split_once uses pretty much exactly the same code. It neither brings performance improvement nor addresses any existing issues - it only make use of some of the stabilized methods of newer rust. I do not tend to reject it, but need still to think how useful this change would be. |
gtema
force-pushed
the
feature/use_split_once
branch
from
2b7fcac to
bb86437
Compare
refactor: Use split_once for safer and simpler key=value parsing
gtema
force-pushed
the
feature/use_split_once
branch
from
bb86437 to
1f5966f
Compare
gtema
approved these changes
Sep 21, 2025
This was referenced Sep 16, 2025
Closed
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use split_once for safer and simpler key=value parsing