Make snyk monitor use the path as the project name #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the snyk monitor action use as the project name if a build file name is specified.
This means that if you don't need the auto-detecting facility where snyk goes and finds all the projects and uploads them separately, you can tie down the project name to something reasonable.
Behold the old (not great), default (terrible) and new (brill) names
The good thing is this kind of matches up with how snyk recommend in their documentation
(from https://docs.snyk.io/snyk-admin/introduction-to-snyk-projects )
The downside is people have to specify the build file to get the benefits of it, and it will affect a couple of other existing projects, so we will need to let them know in case it causes a similar confusion in case this changes (improves?) their project name. https://github.com/search?q=org%3Aguardian+PROJECT_FILE+snyk&type=code