Skip to content

Conversation

@SHession
Copy link
Contributor

@SHession SHession commented Nov 3, 2021

What does this change?

This PR attempts to move our CI away from TeamCity and into GitHub actions using the latest tools from DevX.

NB The action will run for the PR but will not attempt to upload until we add riffRaffUpload to the sbt step.

How to test

We will need to pause TC build and set the build number, we should then be able to test the process end-to-end using CODE.

How can we measure success?

We move away from TeamCity builds and gain all the benefits of GitHub actions!

Have we considered potential risks?

This could be disruptive for Atom Workshop builds.

@SHession SHession requested a review from akash1810 November 3, 2021 17:28
@SHession SHession force-pushed the move-ci-to-github-actions branch from 2d78a32 to 98b0f1e Compare November 3, 2021 17:37
@SHession
Copy link
Contributor Author

SHession commented Nov 3, 2021

@akash1810, it looks like from a cold box the build times are quite similar between TC and GHA but they can be significantly quicker in TeamCity if it's warm. Any thoughts:
image

@akash1810
Copy link
Member

akash1810 commented Nov 3, 2021

@akash1810, it looks like from a cold box the build times are quite similar between TC and GHA but they can be significantly quicker in TeamCity if it's warm. Any thoughts: image

An initial glance suggests a lot of the time in GHA is spent downloading dependencies. Caching these should help:

I've not actually done SBT caching yet, so intrigued to know how to!

There's a fair amount of boilerplate here. If you're interested, we can discuss some composite actions we're creating to simplify this file?

@SHession SHession force-pushed the move-ci-to-github-actions branch from 68a1e62 to 7f52c2f Compare November 4, 2021 09:19
@SHession
Copy link
Contributor Author

SHession commented Nov 4, 2021

@akash1810, thanks for the review, really helpful. I've got it working now and have successfully deployed to CODE. Happy to discuss any other suggestion for improvements but possibly we could iterate on them in another PR?

I've added SBT caching which seems to have improved the build times somewhat. I haven't yet added yarn caching, might improve build speeds a bit more.

@SHession SHession requested review from a team and akash1810 November 4, 2021 09:48
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEAH! Great work!

img

update: was hoping that gif would be bigger/better...

@akash1810
Copy link
Member

I've added SBT caching which seems to have improved the build times somewhat. I haven't yet added yarn caching, might improve build speeds a bit more.

I think yarn caching is provided for free if when the lockfile is on the root of the repo, which it is.

@SHession SHession merged commit 8ac038e into master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants