-
Notifications
You must be signed in to change notification settings - Fork 3
Adds GitHub action CI workflow #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d78a32 to
98b0f1e
Compare
|
@akash1810, it looks like from a cold box the build times are quite similar between TC and GHA but they can be significantly quicker in TeamCity if it's warm. Any thoughts: |
An initial glance suggests a lot of the time in GHA is spent downloading dependencies. Caching these should help:
I've not actually done SBT caching yet, so intrigued to know how to! There's a fair amount of boilerplate here. If you're interested, we can discuss some composite actions we're creating to simplify this file? |
68a1e62 to
7f52c2f
Compare
|
@akash1810, thanks for the review, really helpful. I've got it working now and have successfully deployed to CODE. Happy to discuss any other suggestion for improvements but possibly we could iterate on them in another PR? I've added SBT caching which seems to have improved the build times somewhat. I haven't yet added yarn caching, might improve build speeds a bit more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think |


What does this change?
This PR attempts to move our CI away from TeamCity and into GitHub actions using the latest tools from DevX.
NB The action will run for the PR but will not attempt to upload until we add
riffRaffUploadto the sbt step.How to test
We will need to pause TC build and set the build number, we should then be able to test the process end-to-end using CODE.
How can we measure success?
We move away from TeamCity builds and gain all the benefits of GitHub actions!
Have we considered potential risks?
This could be disruptive for Atom Workshop builds.