Skip to content

Conversation

@emekaokoli19
Copy link
Contributor

@ShreyaR sorry for taking a while, this is kind of what I imagine the callback would look like, also creating an abstract class with abstractmethod would mean the user would have to define all the methods in the subclass to be able to use callbacks which is unnecessary. I also have some questions about the arguments

e.g If a user wants a customized logic for preprocessing, does this mean the prepare function for preprocessing in run.py should be skipped? In that case, what arguments should the after_prepare function take, I assume it should be the return values of before_prepare

I would love to get your thoughts on this

@zsimjee zsimjee closed this Mar 6, 2024
@zsimjee
Copy link
Collaborator

zsimjee commented Mar 6, 2024

Created a discussion here #612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants