Skip to content

Fixes #79. Needed to add unit test for equal and not equal operators. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 2 commits into from
Sep 18, 2022
Merged

Fixes #79. Needed to add unit test for equal and not equal operators. #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60243d1
Fixes #79. Needed to add unit test for equal and not equal operators.
BDisp Sep 18, 2022
d1bf26c
Simplifying the code.
BDisp Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions NStack/strings/ustring.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2230,9 +2230,7 @@ public ustring Replace (ustring oldValue, ustring newValue, int maxReplacements
/// <returns></returns>
public static bool IsNullOrEmpty (ustring value)
{
if (value == null)
return true;
if (value.Length == 0)
if (value?.IsEmpty != false)
return true;
return false;
}
Expand Down
66 changes: 66 additions & 0 deletions NStackTests/ustringTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,5 +821,71 @@ public void IsNullOrEmpty_Accept_Null_Ustring_Arg ()
Assert.False (string.IsNullOrEmpty (ustr.ToString ()));
Assert.False (ustring.IsNullOrEmpty (ustr));
}

[Test]
public void Operator_Equal_Ustring_Versus_String ()
{
ustring? ustr = null;
string? str = null;
Assert.True (ustr == str);
Assert.True (str == ustr);
Assert.True (ustr == null);
Assert.True (str == null);
Assert.False (ustr == "");
Assert.False (str == "");

ustr = "";
str = "";
Assert.True (ustr == str);
Assert.True (str == ustr);
Assert.False (ustr == null);
Assert.False (str == null);
Assert.True (ustr == "");
Assert.True (str == "");

ustr = " ";
str = " ";
Assert.True (ustr == str);
Assert.True (str == ustr);
Assert.False (ustr == null);
Assert.False (str == null);
Assert.False (ustr == "");
Assert.False (str == "");
Assert.True (ustr == " ");
Assert.True (str == " ");
}

[Test]
public void Operator_Not_Equal_Ustring_Versus_String ()
{
ustring? ustr = null;
string? str = null;
Assert.False (ustr != str);
Assert.False (str != ustr);
Assert.False (ustr != null);
Assert.False (str != null);
Assert.True (ustr != "");
Assert.True (str != "");

ustr = "";
str = "";
Assert.False (ustr != str);
Assert.False (str != ustr);
Assert.True (ustr != null);
Assert.True (str != null);
Assert.False (ustr != "");
Assert.False (str != "");

ustr = " ";
str = " ";
Assert.False (ustr != str);
Assert.False (str != ustr);
Assert.True (ustr != null);
Assert.True (str != null);
Assert.True (ustr != "");
Assert.True (str != "");
Assert.False (ustr != " ");
Assert.False (str != " ");
}
}
}