Skip to content

Fixes #83. Ustring ConsoleWidth must return the exactly character size or zero and not the Rune.ColumnWidth if it's negative. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 2 commits into from
Nov 1, 2022
Merged

Fixes #83. Ustring ConsoleWidth must return the exactly character size or zero and not the Rune.ColumnWidth if it's negative. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6149010
Fixes #83. Ustring ConsoleWidth must return the exactly character siz…
BDisp Oct 25, 2022
48db6e0
Amend comment to inform that negative values are replaced with zero.
BDisp Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions NStack/strings/ustring.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,8 @@ public ustring RuneSubstring (int runeStart, int length = 0)
public int RuneCount => Utf8.RuneCount (this);

/// <summary>
/// Returns the number of columns used by the unicode string on console applications. This is done by calling the Rune.ColumnWidth on each rune.
/// Returns the number of columns used by the unicode string on console applications.
/// This is done by calling the Rune.ColumnWidth or zero, if it's negative, on each rune.
/// </summary>
public int ConsoleWidth {
get {
Expand All @@ -1065,7 +1066,7 @@ public int ConsoleWidth {
for (int i = 0; i < blen;) {
(var rune, var size) = Utf8.DecodeRune (this, i, i - blen);
i += size;
total += Rune.ColumnWidth (rune);
total += Math.Max (Rune.ColumnWidth (rune), 0);
}
return total;
}
Expand Down
Loading