Fix Error handling for "4.1 add" and "4.2 remove".#9
Closed
toshiya wants to merge 4 commits intoguillec:masterfrom
toshiya:fix/add_object_error_handling
Closed
Fix Error handling for "4.1 add" and "4.2 remove".#9toshiya wants to merge 4 commits intoguillec:masterfrom toshiya:fix/add_object_error_handling
toshiya wants to merge 4 commits intoguillec:masterfrom
toshiya:fix/add_object_error_handling
Conversation
4.1. add When the operation is applied, the target location MUST reference 4.2. remove The target location MUST exist for the operation to be successful.
Owner
|
@toshiya hello and thanks for this PR. Can you please check and see why some test failed with this PR? I can review this weekend. |
Author
|
@guillec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@guillec
Hi, I'm toshiya. First of all, thank you for this great gem. I like it.
I've been using this gem for sometime and find that some subtle error handlings does not satisfies the RFC specification. (Probably, you already know it.)
This PR contains the fix for the following error cases specified in the RFC.
4.1. add
When the operation is applied, the target location MUST reference
https://tools.ietf.org/html/rfc6902#section-4.1
4.2. remove
The target location MUST exist for the operation to be successful.
https://tools.ietf.org/html/rfc6902#section-4.2