Adapt to undertaker v1.0.0 #87
Conversation
| install: | ||
| - IF %nodejs_version% EQU 0.10 npm -g install npm@2 | ||
| - IF %nodejs_version% EQU 0.10 set PATH=%APPDATA%\npm;%PATH% | ||
| - npm -g install npm@latest |
There was a problem hiding this comment.
are you sure you want to be using npm 3? It's so much slower, and appveyor is already extremely slow.
There was a problem hiding this comment.
npm install EPERM errors frequently occured on appveyor, and it seems that this error can be fixed by using npm3.
ref. npm/npm#9696
sttk
force-pushed
the
adapt_to_undertaker_v1
branch
from
ce579d9 to
e526551
Compare
sttk
force-pushed
the
adapt_to_undertaker_v1
branch
from
e526551 to
7d7a4e8
Compare
|
I've finished modifying the codes. |
lib/shared/log/tasks.js
Outdated
| function isObject(val) { | ||
| return typeof val === 'object' && !Array.isArray(val); | ||
| } | ||
| var _ = require('lodash'); |
There was a problem hiding this comment.
I think people were trying to transition all the gulp dependencies to use lodash.* packages, so this should require lodash.sortby, lodash.isstring and lodash.isplainobject
|
@sttk sorry it took me so long to review. I've commented on some things I noticed. |
|
@phated Don't worry. I know you are busy with other projects. Thank you for reviewing. |
|
@phated I've modified what you pointed out. And I've merged the tests for the flag |
|
Published as 1.2.2 |
|
Excellent work @sttk! Really glad you caught this oversight in my undertaker changes. |
2 participants
This PR is for adapting to both v1.0.0 and previous versions of
undertaker.(And this adds a test case for 100% coverage.)