improve clone

[popomore]

• clone history
• option for deep clone, default: false
• option for cloneBuffer, default: true
• use node-v8-clone for performance, fallback to lodash
• add jshintrc to check code style

[coveralls]

Coverage remained the same when pulling f76a921 on popomore:clone into c801d3d on wearefractal:master.

[coveralls]

Coverage remained the same when pulling 7724121 on popomore:clone into c801d3d on wearefractal:master.

[yocontra]

is this needed with node-v8-clone?

[popomore]

cloneBuffer just copy buffer, don't require clone.

[coveralls]

Coverage remained the same when pulling 037e830 on popomore:clone into c801d3d on wearefractal:master.

[yocontra]

want to send another pull request adding in the stream dereferencing?

[sindresorhus]

@contra using a native dep is not a good idea for a myriad of reasons:

• It will fail on most computers as few have the required toolchain, especially on Windows. Leaving this mostly moot in benefits, but high in downsides:
• The gyp error makes people believe the install failed: https://twitter.com/ArnaudHuc/status/505326409884397569
• node-v8-clone takes almost 2 minutes to install (because it downloads node), on my fast OS X 10.9 machine with the required toolchain to build.

[popomore]

Yeah, so it's an option dep, it will fallback to lodash, other idea for clone performance?—
Sent from Mailbox for iPhone

On Fri, Aug 29, 2014 at 8:36 PM, Sindre Sorhus notifications@github.com
wrote:

@contra using a native dep is not a good idea for a myriad of reasons:

• It will fail on most computers as few have the required toolchain, especially on Windows
• The gyp error makes people believe the install failed: https://twitter.com/ArnaudHuc/status/505326409884397569

- node-v8-clone takes almost 2 minutes to install (because it downloads node).

Reply to this email directly or view it on GitHub:
#32 (comment)

[yocontra]

@sindresorhus So it's outputting the gyp error even though it is listed as an optionalDependency? :(

[sindresorhus]

@popomore ⬆️ I think you went with a native dep too fast without looking into why it's slow.

@contra Yes

[popomore]

I like pure javascript too, we should find whether it's slow exactly and why?

[yocontra]

@popomore Just an FYI the history PR and this PR conflicted, history (an array) was not being deep cloned unless specifically told to - this is a special case like stat that always needs to be deep. I patched this already (0.4.1).

I'm okay with going pure JS, I wish native deps weren't such a hassle because the v8 clone is an order of magnitude faster. Is there anything faster than JS?

[popomore]

@contra ok, that's my fault.