Skip to content

Bug in Item3D::IsAboveBelow #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustav21 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bug in Item3D::IsAboveBelow #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1133deb
Bug in Item3D::IsAboveBelow
gustav21 Sep 21, 2016
db2c534
Changes in AboveBelow test
gustav21 Sep 22, 2016
a5d759e
Add AboveBelowBug test
gustav21 Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SourceFiles/Item3D.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ bool Item3D::IsAboveBelow( item_t other )
double ow1 = other->getWLocation();
double ow2 = ow1 + other->side_1()->size() - 1;
double ol1 = other->getLLocation();
double ol2 = ow2 + other->side_3()->size() - 1;
double ol2 = ol1 + other->side_3()->size() - 1;


// cout << mw1 <<" "<< mw2 <<" "<< ml1 <<" "<< ml2 <<"\n"<<
Expand Down
21 changes: 21 additions & 0 deletions unit_test/unit_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,27 @@ TEST( OverlapArea )
CHECK_CLOSE( i3->AreaWidthLength() / 2, i3->OverlapArea( i2 ), 0.1 );

}

TEST(AboveBelowBug)
{
std::shared_ptr<Item> i1(new Item3D());
i1->set_side_1(new Side(1, 'w'));
i1->set_side_2(new Side(2, 'h'));
i1->set_side_3(new Side(3, 'l'));
i1->setWLocation(0);
i1->setHLocation(0);
i1->setLLocation(7);
std::shared_ptr<Item> i2(new Item3D());
i2->set_side_1(new Side(1, 'w'));
i2->set_side_2(new Side(2, 'h'));
i2->set_side_3(new Side(3, 'l'));
i2->setWLocation(0);
i2->setHLocation(200);
i2->setLLocation(5);

CHECK(i1->IsAboveBelow(i2));
}

int main(int argc, char *argv[])
{
return raven::set::UnitTest::RunAllTests();
Expand Down