Apt-Install #147
Closed
Apt-Install #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check_install_pkgs - check if pkgs is installed if not installs it. * apt_update_skip - Skips 'apt update' if cache not older than one Hour
* PreInstall Module provides a 'apt full-upgrade' to bring latest updates to build-Image * Also, it can be configured to install all dependent packages for your Image. See preinstall/config for configuration by default only upgrade and cleanup are performed.
Forgot to set missing_pkgs Variable to an Array
Owner
|
I would call it |
Contributor
Author
|
I think thats really a better option. So I called it 'apt-install', what do you think? |
Contributor
Author
|
after renaming it doesnt work anymore, so closed for now. |
Owner
|
Ok, any idea why its not working? It should work after such a change. |
Contributor
Author
|
Indeed, it seems that even trough globbing prevention ${foo}, the APT in that Var gets lost and then all according Vars arent complete. So, I fixed that by renaming to pkgupgrade. Also, however the - leads to Errors what it shouldn't do. I will open a new PR, including a small improvment to #146, the Error Message if found and installed is misleading. Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See preinstall/config for configuration
by default only upgrade and cleanup are performed.
This PR also includes PR #146 .
You have the choice, this PR is not independent because it reuses "apt_update_skip" function from PR #146.
I would be happy if you merge this one.
Regards