Small character device verification cleanup #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezanzeb
changed the title
sezanzeb
changed the title
sezanzeb
force-pushed
the
refactor_character_device_verification
branch
from
e9e360e to
6d3b590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #228
Because the quick fix for theraiseis still, in some way, using exceptions for control flow, and I don't like raising some exception just to replace it with a different one shortly afterwards. Also, OSError is wrong there and just happened to work for the time being. I also wanted to avoid solutions that define msg multiple times (inside the if, and inside the except), and avoid creating/formatting msg before any exception happened. So it had to beexcept: passto raise the exception at the end of the method. This is somewhat hard to get beautiful and good-practice.edit: looks pretty with assert.
Added 2 more tests.