H5P Question Set Setup CSS Var Missing Bug

[michael1-0]

Hello, I have this problem where if I install the h5p-question-set library using the appropriate commands mentioned in the readme, the CSS vars get broken or missing:

Taking a look at the dev console shows that the CSS root variables are missing.

To recreate this bug, simply install using h5p core then h5p setup h5p-question-set, and create a question set content.

I have installed the h5p core libraries.

I also notice that the version of h5p multiple choice library on WordPress is more outdated compared to installing it using this h5p toolkit:
Multi choice version in this toolkit:

Multi choice version on WordPress:

I also notice that the implementation code is slightly different as well, comparing those two.

Installing h5p core libraries then copy and pasting the h5p question set library along with its dependencies from WordPress uploads/h5p/libraries folder (skipping the h5p setup h5p-question-set command), fixes the issue, as the older version (WordPress version) does not use CSS vars.

But breaks (infinite loading) when trying to upload the packed .h5p library onto WordPress.

[otacke]

This is not a bug with the H5P CLI tool.

When you set up libraries using the setup command, it will fetch the latest master branch from the repositories. That branch does not contain the release version, so you are likely to see differences.

The custom CSS variable that you see is part of the upcoming new theming feature of H5P. Support for that feature has not been merged to the master branch of the H5P CLI tool, but it's in the feature/redesign branch.

The thing that is still off though is that for some reason the master branch of the MultipleChoice content type already uses those variables. Probably a misdirected pull request. Those should only be found on the feature/redesign branch. I'll let H5P Group know.

[VildeStabell]

Hi @michael1-0, as @otacke mentions, this was caused by an accidental merge from an ongoing project branch. You can get around it temporarily by running the following from your libraries folder:

h5p utils checkout legacy *
h5p utils build -i *

This will use the released version of the content types you've installed. Keep in mind that you would have to switch back to any branch you've created/checked out intentionally

[michael1-0]

Thank you for the answers! Should I move this issue to h5p-multi-choice?

[VildeStabell]

@michael1-0 You can keep it here, since it relates to several content types.