Sidepanel and email sync fixes#9
Merged
vladiacob merged 5 commits intohackajob:hackajob-developmentfrom Sep 25, 2025
Merged
Conversation
…l. This was previously removed by frappe crm team
…ferences in loaded modules
e503cd2 to
19551d6
Compare
…fter_install hook
vladiacob
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements and simplifications to the frontend layout and navigation logic, primarily focusing on removing the Dashboard page and streamlining how fields are handled in the Side Panel components. The changes enhance robustness when working with dynamic field definitions and simplify the user flow to always default to the Leads page.
Navigation and Routing Updates:
frontend/src/router.js,frontend/src/components/Layouts/AppSidebar.vue) [1] [2] [3] [4]Side Panel Field Handling Improvements:
SidePanelLayout.vueandSidePanelModal.vueto robustly handle fields that may be defined as either full objects or simple string fieldnames, ensuring consistent rendering and saving of fields. (frontend/src/components/SidePanelLayout.vue,frontend/src/components/Modals/SidePanelModal.vue) [1] [2] [3]frontend/src/components/SidePanelLayout.vue) [1] [2]Field Type Restrictions:
frontend/src/components/SidePanelLayoutEditor.vue)Minor Codebase Cleanups:
frappeincrm/overrides/email_receive.pyfor completeness.frontend/src/components/SidePanelLayout.vue)Edit:
Added function to check if private/files folder exists and create it if not. This is required as syncing email attachments is dependent on private/files folder being present