Skip to content

Conversation

@j4y-boi
Copy link
Member

@j4y-boi j4y-boi commented Feb 19, 2025

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[X] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[X] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[X] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[X] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[X] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[X] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

@vercel
Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:51pm

@UnusualTitan711x
Copy link
Contributor

Hi there. Cool macropad.
The only issue I have is no images.
Please add images of your PCB design, schematics, case parts and your fully assembled hackpad.

Otherwise, everything looks great. Here's my PR: #405

@return-misaPuding
Copy link
Contributor

(please read through the entire thing, as these mistakes are quite big. my accepted PR is #634 .)

obrazek
the bit that sticks out from the xiao (USB connector) should be almost fully outside of edge.cuts, else you can´t connect it


obrazek
you probably forgot to use the actual oled display footprint, so you didn´t notice how big it is - importing the footprint for a 128x64 SSD1306 display and aligning it with your connector footprint, it collides with the rotary encoder and sticks out of the board edge (so presumable also out of the case)
since your PCB is 100x72mm and you can´t make it larger horizontally to fit in the oled display, i suggest either removing it from the BoM entirely or moving the diodes of row2 (+the rgb led D1) somewhere else (like below their respective switches):
obrazek


obrazek
your switches aren´t perfectly aligned (the outer boxes should be coincident, but you have gaps between them), so the plate generated with keeb plate generator will not work.
this can be fixed by choosing one of the correct switches as "correct", placing a grid origin on it, then adding a new grid of 19.05/8 mm, and moving the rest of the switches to align them perfectly.
when corrected, it should look like this:
obrazek

@return-misaPuding
Copy link
Contributor

obrazek
i think this shows the problem with the USB port pretty clearly

Copy link
Collaborator

@Taran-the-Idiot Taran-the-Idiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything puding said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants