-
Notifications
You must be signed in to change notification settings - Fork 452
Add divpreetpad #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add divpreetpad #562
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to put your project int the hackpads folder instead of the root of the project! Else lgtm from #4
|
How do I change that? I suck at PR's 😭 |
|
|
oh shoot, just took a look, |
|
Alright, made the changes required. |
cheyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM #4
|
looks great! (My PR#438) |
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh what is this?
its a pr for hackpad #v2! |
|
You don't have anything there though |
|
Well I don't see anything in your fork. And you only have a single file changed |
|
hmm, i just took a look and it says its a submodule, if thats the problem i can resolve it.. this is the project repo though... |
|
the reviewers said it was ok, so i didnt know i was in the wrong |
|
Can you just add it normally |
|
@divpreeet is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
|
hey! @Overlord-Runt do you mind taking a look now! i added it normally. |
Taran-the-Idiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! thanks for actually replying(unlike 90% of others).
fill out this form later once it opens(i will reply here when it does)
|
alright! thanks alot! its finally been merged! ill wait for your message for the form. |
|
im dumb wrong form. https://forms.hackclub.com/hackpadv2 is the right form |
Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.
Check off the following to let the reviewers know you've done everything:
[✅] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[✅] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[✅] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[✅] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[✅] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[✅] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:
If you're unsure about the format, make sure to check out this example and follow the format there.
If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!