Skip to content

Conversation

@divpreeet
Copy link
Contributor

@divpreeet divpreeet commented Feb 20, 2025

Ready to submit your project? Nice job! Hopefully you've read the submission guidelines. If not, make sure to read them first.

Check off the following to let the reviewers know you've done everything:
[✅] I HAVE RAN DRC ON MY DESIGN WITH ZERO ERRORS (Silkscreen errors are okay)
[✅] I HAVE BRANDED ALL MY PARTS (PCB, CASE) WITH MY HACKPAD'S NAME
[✅] I HAVE MADE SURE MY 3D PRINTED PARTS DO NOT REQUIRE SUPPORTS (Text branding overhang is okay)
[✅] I HAVE MADE SURE TO INCLUDE TOLERANCES (0.25mm)
[✅] MY HACKPAD'S PCB IS UNDER 100mm x 100mm, I DO NOT HAVE MORE THAN 16X SWITCHES, 2X ROTARY ENCODERS, 1X OLED, 16X LEDS.
[✅] IN MY FOLDER, THERE IS A README.MD FILE THAT CONTAINS THE FOLLOWING INFORMATION:

  • Full render including all the parts
  • A few sentences about the inspiration and challenges
  • BOM
  • Photos of the Schematic, PCB, and case

If you're unsure about the format, make sure to check out this example and follow the format there.

If this PR isn't a submission, that's okay too! Please remove the above boxes and explain what the pull request is for! If there's anything about this PR template that seems confusing, send a message in #hackpad in slack!

@vercel
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 0:07am

Copy link
Contributor

@cheyao cheyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put your project int the hackpads folder instead of the root of the project! Else lgtm from #4

@divpreeet
Copy link
Contributor Author

How do I change that? I suck at PR's 😭

@cheyao
Copy link
Contributor

cheyao commented Mar 9, 2025

git clone https://github.com/divpreeet/hackpad/
cd hackpad
rm -rf hackpads/divpreetpad
mv divpreetpad hackpads
git add .
git commit -m "Fix"
git push

@divpreeet
Copy link
Contributor Author

oh shoot, just took a look, divpreetpad is in the root folder, my apologies, the problem is that github is failing everytime

@divpreeet
Copy link
Contributor Author

Alright, made the changes required. divpreetpad is now in hackpad/divpreetpad, thanks alot for the help @cheyao! lmk if any more changes are required.

Copy link
Contributor

@cheyao cheyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM #4

@aryn-pathak
Copy link
Contributor

looks great! (My PR#438)

@divpreeet divpreeet requested a review from cheyao July 14, 2025 19:23
Copy link
Collaborator

@Taran-the-Idiot Taran-the-Idiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh what is this?

@divpreeet
Copy link
Contributor Author

uh what is this?

its a pr for hackpad #v2!

@Taran-the-Idiot
Copy link
Collaborator

You don't have anything there though

@Taran-the-Idiot
Copy link
Collaborator

Well I don't see anything in your fork. And you only have a single file changed

@divpreeet
Copy link
Contributor Author

hmm, i just took a look and it says its a submodule, if thats the problem i can resolve it.. this is the project repo though...

@divpreeet
Copy link
Contributor Author

the reviewers said it was ok, so i didnt know i was in the wrong

@Taran-the-Idiot
Copy link
Collaborator

Can you just add it normally

@vercel
Copy link

vercel bot commented Oct 12, 2025

@divpreeet is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@divpreeet
Copy link
Contributor Author

hey! @Overlord-Runt do you mind taking a look now! i added it normally.

Copy link
Collaborator

@Taran-the-Idiot Taran-the-Idiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! thanks for actually replying(unlike 90% of others).
fill out this form later once it opens(i will reply here when it does)

@Taran-the-Idiot Taran-the-Idiot merged commit 2d81dc2 into hackclub:main Oct 12, 2025
1 check failed
@divpreeet
Copy link
Contributor Author

alright! thanks alot! its finally been merged! ill wait for your message for the form.

@Taran-the-Idiot
Copy link
Collaborator

im dumb wrong form. https://forms.hackclub.com/hackpadv2 is the right form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants