Skip to content

Conversation

@GearBoxFox
Copy link
Contributor

Ready to make a PR? Great! Make sure your directory structure looks like this:

├── CAD
│   ├── case.stl
│   └── plate.dxf
├── firmware
│   └── rp2040.bin
└── PCB
├── macropad.pro
└── macropad.sch

(The file names do not matter, just the folders)

@vercel
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hackpad ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 11:16pm

@GearBoxFox
Copy link
Contributor Author

I meant to add to the original PR comment that I'd like a green case, and I would like to assemble the case/PCB myself.

@github-actions
Copy link

Hey!! Nice job on your hackpad submission. This is alexren // @qcoral sending this automation to let you know that the submission guidelines have been updated, please follow https://hackpad.hackclub.com/submitting again. Sorry for the confusion!! Hopefully this won't be needed again.

@cheyao
Copy link
Contributor

cheyao commented Oct 22, 2024

Hey GearBoxFox! I am currently reviewing your pull request and I've found several problems with it.

In the schematic, your schematic for the joystick is not matching with the footprint, and the seed's schematic is the wrong one (It works but oh well)

In the PCB you got a trace here that you ran into a hole:
image
That is 100% not going to work. I recommend running the DRC.

And here, this blue trace that you ran all around that hole could be shortened a lot with one or two vias. Running that close around a hole is generally not a good idea.
image

And here in your firmware, you should use the GP pin numbers (The gray ones on this picture)
image

Finally for your case, uh well I don't have anything to say. That is a PCB, not a case.

Anyways gl for your submission!

@GearBoxFox
Copy link
Contributor Author

Thank you for reviewing! I'll update the schematic for the XAIO and fix the traces. When I made my schematic, the guide still said to use that schematic + footprint. As for the case, I'll check the .stl files I exported, I only had the case files selected when I exported them so the PCB shouldn't be in them.

@GearBoxFox
Copy link
Contributor Author

I double-checked the PCB submission, DRC initially missed those two errors but found them the second time. As for the CAD file and firmware pins, those had been set properly on my local machine, so I believe Git simply decided to mess with me.

Copy link
Contributor

@jpt1729 jpt1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#7

@cheyao
Copy link
Contributor

cheyao commented Oct 24, 2024

LGTM
#4

@qcoral
Copy link
Member

qcoral commented Oct 24, 2024

Looks Good To Me!

https://forms.hackclub.com/hackpad <- make sure you include any fasteners you may need!

@qcoral qcoral merged commit 8e254ee into hackclub:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants