Add Dockerfile; add GitHub Actions build#9
Conversation
There was a problem hiding this comment.
Why are you using the Sourceforge mirror of exiftool, doing a source build and not the Debian package?
libimage-exiftool-perl Trixie version 13.25+dfsg-1
There was a problem hiding this comment.
I had originally set this up with the Debian package but since I've been consistently running into difficulties with the test suite I decided to follow the directions in BUILD.md and install the latest version of ExifTool following their instructions just to rule out an older version of ExifTool as a possible culprit. Once it passes all the tests reliably it is my intent to attempt to transition to the Debian packaged ExifTool.
There was a problem hiding this comment.
Why do you need a docker login to use debian stable? I believe you can pull the public image without a login.
There was a problem hiding this comment.
The Docker login step is to authenticate with the GitHub Container Registry so once the next step generates a Docker image it can be pushed up to the registry.
Note: if you want merging this PR to push the first image up to the container registry, please review the instructions in CI.md to set up the necessary Actions variables and a PAT secret so the container image can be pushed up to the container registry (if you are an owner in the hackerfactor/SEAL-C repository then skip the first fork step). The DOCKER.md file that is included in this PR is assuming that the steps in
CI.mdare taken before this PR is merged.Missing from this PR
SIGNMYDATA_APIKEYandSIGNMYDATA_IDenvironment variables set succeeds (withdocker build --secret id=apikey,env=SIGNMYDATA_APIKEY --secret id=signid,env=SIGNMYDATA_ID --no-cache -t sealtool:latest .).DOCKER.mdon how to follow the same steps in Windows. Doing directory mapping between Windows and Docker Containers is fidgety, I need to do more testing before I'm ready to document that.