Update navbar 1307#1317
Merged
MattPereira merged 14 commits intohackforla:developmentfrom Mar 13, 2023
Merged
Conversation
MattPereira
suggested changes
Mar 9, 2023
MattPereira
reviewed
Mar 10, 2023
MattPereira
approved these changes
Mar 10, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…update-navbar-1307
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@MattPereira @spiteless |
MattPereira
suggested changes
Mar 13, 2023
MattPereira
suggested changes
Mar 13, 2023
MattPereira
suggested changes
Mar 13, 2023
Member
Author
|
The requested changes have been completed. |
This comment was marked as resolved.
This comment was marked as resolved.
MattPereira
reviewed
Mar 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Good catch! Just updated for mobile and moved the margins on the box inside the |
MattPereira
approved these changes
Mar 13, 2023
Contributor
There was a problem hiding this comment.
Well done @plang-psm 🎉
The new navbar is soooo much more concise and readable! 🚀
And great job with the JSX comments that help us understand which user access level gets which navbar links. Love the way you used arrows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1307
What changes did you make and why did you make them ?
.scssfile as it is no longer needed.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied