Skip to content

Update navbar 1307#1317

Merged
MattPereira merged 14 commits intohackforla:developmentfrom
plang-psm:update-navbar-1307
Mar 13, 2023
Merged

Update navbar 1307#1317
MattPereira merged 14 commits intohackforla:developmentfrom
plang-psm:update-navbar-1307

Conversation

@plang-psm
Copy link
Member

@plang-psm plang-psm commented Mar 8, 2023

Fixes #1307

What changes did you make and why did you make them ?

  • Changed the 'project/:projectId' route to 'projects/:projectId' to match the '/projects' page and to maintain active styling on the tabs.
  • Commented out the previous .scss file as it is no longer needed.
  • Add an improved cropped version of the HfLA svg in the svg folder.
  • Imported Source Code Pro into the index.scss.
  • Removed the below due to 'unused' console errors:
import '../sass/Navbar.scss';
import { authLevelRedirect } from '../utils/authUtils';
let loginRedirect = '/admin';
if (auth?.user) {
loginRedirect = authLevelRedirect(auth.user);
}

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied image
Visuals after changes are applied image image

@MattPereira MattPereira self-requested a review March 9, 2023 16:58
@plang-psm plang-psm requested a review from MattPereira March 9, 2023 22:00
@MattPereira MattPereira self-requested a review March 10, 2023 00:47
MattPereira

This comment was marked as resolved.

@plang-psm plang-psm requested a review from MattPereira March 10, 2023 00:53
@plang-psm

This comment was marked as resolved.

@trillium

This comment was marked as resolved.

@plang-psm

This comment was marked as resolved.

@MattPereira

This comment was marked as resolved.

@plang-psm

This comment was marked as resolved.

@MattPereira

This comment was marked as resolved.

MattPereira

This comment was marked as resolved.

@trillium

This comment was marked as resolved.

@MattPereira

This comment was marked as resolved.

@plang-psm

This comment was marked as resolved.

@MattPereira

This comment was marked as resolved.

@plang-psm
Copy link
Member Author

@MattPereira @spiteless
Styling has been updated and should resemble the Figma design. Let me know if you find any errors. 🫡

@plang-psm
Copy link
Member Author

@MattPereira

The requested changes have been completed.

@plang-psm plang-psm requested a review from MattPereira March 13, 2023 18:42
@MattPereira

This comment was marked as resolved.

@MattPereira

This comment was marked as resolved.

@plang-psm
Copy link
Member Author

@MattPereira

Good catch! Just updated for mobile and moved the margins on the box inside the sx for formatting.

@plang-psm plang-psm requested a review from MattPereira March 13, 2023 20:17
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @plang-psm 🎉

The new navbar is soooo much more concise and readable! 🚀

And great job with the JSX comments that help us understand which user access level gets which navbar links. Love the way you used arrows

@MattPereira MattPereira merged commit 9dfc850 into hackforla:development Mar 13, 2023
@jbubar jbubar added size: 2pt Can be done in 7-12 hours and removed x-size: 3pt labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: Front End size: 2pt Can be done in 7-12 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update-navbar

4 participants