feat: add validation to editableField#1425
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hey Evan, Can you add a bit of context on the changes you've made to the codebase and why they've been made? I know that we have the issue markes, and that you've referenced them within this PR, but it's good practice to put a summary together so that whoever is reviewing it has an easier time following along with the changes you've submitted. |
There was a problem hiding this comment.
We're planning on dropping the edits to editableField.js and keeping the utils validator
|
@evanyang1 |
trillium
left a comment
There was a problem hiding this comment.
Thanks for the validation functions Evan!
Fixes #1367 #1368 #1369 #1370 #1363 #1402
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied