Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Closed
trillium
requested changes
Aug 24, 2023
Member
trillium
left a comment
There was a problem hiding this comment.
Great work!
I've left a few requests for changes, please update those and then we'll get it merged!
Member
|
Feel free to do these things a different way if you see fit, but I updated the code to revert to prev state on 2nd Edit button click, and added back in the Manually Triggered Event Checkin section here: |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Pull request add a few more tasks which is now complete:
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1470
What changes did you make and why did you make them ?
Additional comments
Edit project page validation needs to be updated to read current project details on the Edit Page. The validation isn't picking up the passed values for the project info and returns a validation error when you try to save. It does however, remove the highest error, one by one, if you continue to save. Eventually they all clear and the save submits.api/ProjectServiceApi/create. It is currently handling a POST request and returning the project ID. I believe these should be separate functions since they serve different purposes.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Before
After