Create ValidatedTextField#1485
Merged
trillium merged 4 commits intohackforla:developmentfrom Aug 29, 2023
Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
plang-psm
suggested changes
Aug 28, 2023
Member
plang-psm
left a comment
plang-psm
left a comment
There was a problem hiding this comment.
Great job @spiteless . Overall the PR optimizes the form by reducing code, and making it versatile. I do have some requested changes I'd like to see before merging.
- Brief comment that explains the use/need of the validated text field, description of complicated props, just so future devs have a better understanding. Something as simple as 'register - react hook forms method used for the project form' etc.
- Rename parts/medium to be a little more descriptive. Considering we may be adding reusable drop downs, etc. maybe naming the file 'form utilities'? Or something along those lines so it is clear these are connected to the project form and their relationship to that form.
Handle isEdit without a ternary operator
Library imports first, local imports second separated by line break
trillium
force-pushed
the
ts.1482.validated_text_field
branch
3 times, most recently
from
d36b9fb to
aa6d7e8
Compare
MattPereira
approved these changes
Aug 28, 2023
Contributor
MattPereira
left a comment
MattPereira
left a comment
There was a problem hiding this comment.
@spiteless nice refactor on this one! Local testing looks good 👍
Also liked @plang-psm suggestion to add explanatory comment's to the ValidatedTextField component
The ProjectForm component is looking so much better thanks to both of you! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1482
Part of larger refactor #1481
What changes did you make and why did you make them ?
isEditsimpler in ValidatedTextFieldScreenshots of Proposed Changes Of The Website
None, this only refactors a component