fix: Update generateEventData to handle daylight savings#1579
Merged
jbubar merged 2 commits intohackforla:developmentfrom Feb 10, 2024
Merged
fix: Update generateEventData to handle daylight savings#1579jbubar merged 2 commits intohackforla:developmentfrom
jbubar merged 2 commits intohackforla:developmentfrom
Conversation
* Move generateEventData to its own file * Add tests for generateEventData Co-authored-by: danieldkim42 <danieldkim42@users.noreply.github.com>
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
trillium
requested review from
MattPereira,
bkmorgan3,
danieldkim42 and
jbubar
danieldkim42
approved these changes
Feb 10, 2024
Member
danieldkim42
left a comment
danieldkim42
left a comment
There was a problem hiding this comment.
Everything looks good. File changed from createRecurringEvents.js to generateEventData.js. Test file covers daylight savings and normal time checks. generateEventData now successfully checks daylight time before creating new event data
jbubar
approved these changes
Feb 10, 2024
Member
jbubar
left a comment
jbubar
left a comment
There was a problem hiding this comment.
still looking into this. but I wanted to approve it so that if you felt like you needed to merge it you could
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1411
What changes did you make and why did you make them ?