Skip to content

Update HTML components to MUI: ./src/components/dashboard/AddTeamMember.js#1692

Closed
nora-zajzon wants to merge 3 commits intohackforla:developmentfrom
nora-zajzon:nora
Closed

Update HTML components to MUI: ./src/components/dashboard/AddTeamMember.js#1692
nora-zajzon wants to merge 3 commits intohackforla:developmentfrom
nora-zajzon:nora

Conversation

@nora-zajzon
Copy link
Member

Fixes #1680

What changes did you make and why did you make them ?

  • I changed all HTML components to applicable MUI components

@github-actions
Copy link

github-actions bot commented Jul 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-nora development
git pull https://github.com/nora-zajzon/VRMS.git nora

@nora-zajzon nora-zajzon closed this Jul 7, 2024
@nora-zajzon nora-zajzon reopened this Jul 7, 2024
@nora-zajzon
Copy link
Member Author

accidentally closed. There are some files in this that are a part of a previous pull request #1688

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve these changes. The changes to HandleAuth and EditUser should technically not be a part of fixing #1680, but that's okay this time around.

Changes look good, I like you ussing props.isSuccess && and props.isError && instead of ternary ? <component /> : null

Thank you :)

Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me and @trillium already discussed that some of these items shouldn't technically be part of the #1680 fix.

I noticed issue #1680 was un-assigned, so I assigned it for you @nora-zajzon — just a heads up (:

@pluto-bell pluto-bell added the ready for dev lead Add to issue when dev lead needs to take some action label Oct 28, 2024
@JackHaeg
Copy link
Member

JackHaeg commented Feb 6, 2025

Per @trillium - some of the other PRs have created merge conflicts. Closing this PR and moving issue back to prioritized backlog to be picked up by an active team member.

@JackHaeg JackHaeg closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants