Migrated newUserForm.js to MUI#1726
Closed
ntrehan wants to merge 2 commits intohackforla:developmentfrom
Closed
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
trillium
approved these changes
Aug 20, 2024
Member
trillium
left a comment
There was a problem hiding this comment.
Thanks for putting in the work on this one. It was definitely more.
We're planning on removing the HackNight question later on, so no need to remove switch that to an MUI date picker
Member
@trillium Please take a look at this PR and make sure that it can be merged given Angela's changes. |
Member
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1693
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals of empty form before changes are applied
Visuals of empty after changes are applied
Visuals of filled form before changes are applied
Visuals of filled form before changes are applied
Visuals of filled form after changes are applied
Test 1 : create a new user that has never attended Hack Night before. Result - Passed
Test 2 : create a new user that has attended Hack Night before. Result - Passed