Skip to content

Migrated edit users to Material UI#1727

Merged
trillium merged 4 commits intohackforla:developmentfrom
ntrehan:1723
Jun 17, 2025
Merged

Migrated edit users to Material UI#1727
trillium merged 4 commits intohackforla:developmentfrom
ntrehan:1723

Conversation

@ntrehan
Copy link
Member

@ntrehan ntrehan commented Aug 14, 2024

Fixes #1723

What changes did you make and why did you make them ?

  • Migrated editUsers.js to Material UI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1723 development
git pull https://github.com/ntrehan/VRMS.git 1723

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More MUI progress, thank you :)

@JackHaeg
Copy link
Member

@trillium I see that you approved these changes on this PR. Can we go ahead and merge?

@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 14, 2025
@JackHaeg
Copy link
Member

JackHaeg commented Mar 11, 2025

@trillium & @ntrehan:

  • This PR was completed prior to the introduction of the VRMS Admin feature (that allows admins to promote/demote other admins).
  • The VRMS Admin feature is currently implemented in Dev (see attached screenshot below)

Question:

  • Will this PR result in the "VRMS Admin" component using MUI styling, or will it default to the previous styling?
  • If it will result in the old styling or merging will be difficult with these new changes, should we either update this PR with this fix, or create a new issue to track this change entirely?
Screenshot of current Dev build with "VRMS Admin" feature

Edit Users Page with VRMS Admin feature

@JackHaeg
Copy link
Member

@trillium Please see my comment above and let me know your thoughts - #1727 (comment)

@trillium trillium merged commit c4d092a into hackforla:development Jun 17, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Placeholder Text on MUI Selection Component on: ./src/components/user-admin/EditUsers.js

3 participants