added MUI modal to edit meeting times#1741
added MUI modal to edit meeting times#1741nora-zajzon wants to merge 1 commit intohackforla:developmentfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
jng34
left a comment
There was a problem hiding this comment.
@nora-zajzon,
This looks great! The open & close functionalities work as expected.
Just a note:
- In mobile view: The
Modalcomponent in landscape mode does not seem to be adaptive on various mobile devices, such as the Samsung Galaxy and iPhone (see screenshots below). Perhaps usingGridorContainermay fix this? - Ref: MUI Responsive UI
Thank you!
|
@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those. |
|
@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those. |
|
Per @trillium's direction, we are closing this PR due to merge conflicts and changes that will be difficult to overcome due to more recent edits on VRMS. This PR will be used as a reference when creating an updated fresh PR should be submitted |


Fixes #1724
What changes did you make and why did you make them ?
Visuals before changes are applied
Visuals after changes are