Skip to content

added MUI modal to edit meeting times#1741

Closed
nora-zajzon wants to merge 1 commit intohackforla:developmentfrom
nora-zajzon:editTimesModal2
Closed

added MUI modal to edit meeting times#1741
nora-zajzon wants to merge 1 commit intohackforla:developmentfrom
nora-zajzon:editTimesModal2

Conversation

@nora-zajzon
Copy link
Member

@nora-zajzon nora-zajzon commented Sep 10, 2024

Fixes #1724

What changes did you make and why did you make them ?

  • Changed the edit meeting times to a modal
Visuals before changes are applied Screenshot 2024-09-03 at 2 27 48 PM applied
Visuals after changes are Screenshot 2024-09-03 at 10 54 25 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-editTimesModal2 development
git pull https://github.com/nora-zajzon/VRMS.git editTimesModal2

Copy link
Member

@jng34 jng34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nora-zajzon,
This looks great! The open & close functionalities work as expected.

Just a note:

  • In mobile view: The Modal component in landscape mode does not seem to be adaptive on various mobile devices, such as the Samsung Galaxy and iPhone (see screenshots below). Perhaps using Grid or Container may fix this?
  • Ref: MUI Responsive UI
Screenshots in mobile landscape mode pr1741 pr1741-screen2

Thank you!

@JackHaeg
Copy link
Member

@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those.

@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Mar 3, 2025
@JackHaeg
Copy link
Member

JackHaeg commented Mar 4, 2025

@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those.

@JackHaeg
Copy link
Member

JackHaeg commented May 8, 2025

Per @trillium's direction, we are closing this PR due to merge conflicts and changes that will be difficult to overcome due to more recent edits on VRMS. This PR will be used as a reference when creating an updated fresh PR should be submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Edit Meeting Times base component to an MUI modal

3 participants