migrate returninguser to mui#1764
Merged
JackHaeg merged 4 commits intohackforla:developmentfrom May 15, 2025
Merged
Conversation
pluto-bell
approved these changes
Nov 10, 2024
Member
pluto-bell
left a comment
pluto-bell
left a comment
There was a problem hiding this comment.
Great work, replaced all HTML components on this page with MUI ones. The changes look good to me.
JackHaeg
added
complexity: small
ready for 2nd review
jng34
approved these changes
Mar 13, 2025
Member
jng34
left a comment
jng34
left a comment
There was a problem hiding this comment.
I second @pluto-bell - the migration from HTML to MUI components looks good!
As noted in one of the earlier team meetings, CSS is not necessary as it will be addressed during the revamping of the UI, but it should be fine to leave the code as is.
Member
|
@pluto-bell @angela-lee1 @JackHaeg |
Member
|
Hi @jng34! Thanks for taking a look at this. Yes, I think we can go ahead and merge given that there are no merge conflicts & 2 approving reviews to this page. I'll merge now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1716
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
[image](
)
Visuals after changes are applied
[image](
)