update userprofile to mui#1766
Conversation
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Looks like a good PR to me, thanks for putting work into these changes!
Would be nice to check on seeing if Tpyography element needs component='h3' and variant='h3' but not requried
| <div className="profile__header"> | ||
| <h3 className="profile__title">My Profile</h3> | ||
| </div> | ||
| <Box> |
There was a problem hiding this comment.
Eventually change hex code to a stored variable, but for now this fine
| </div> | ||
| <Box> | ||
| <Box style={{ backgroundColor: '#bad3ff' }}> | ||
| <Typography |
There was a problem hiding this comment.
Curious if one of these is redundant, I tought that Typography variant="h3" would make this component an h3 element already
| <Typography | ||
| variant="h3" | ||
| component="h3" | ||
| style={{ |
There was a problem hiding this comment.
We may be able to have this be declared through the MUI config file later on
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Looks like a good PR to me, thanks for putting work into these changes!
Would be nice to check on seeing if Tpyography element needs component='h3' and variant='h3' but not requried
2 participants
Fixes #1715
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
[image](
)
Visuals after changes are applied
[image](
)