Skip to content

Google Drive Form Validation #1796

Merged
kurtmgray merged 4 commits intohackforla:developmentfrom
nora-zajzon:GoogleDriveValidation
Mar 11, 2025
Merged

Google Drive Form Validation #1796
kurtmgray merged 4 commits intohackforla:developmentfrom
nora-zajzon:GoogleDriveValidation

Conversation

@nora-zajzon
Copy link
Member

@nora-zajzon nora-zajzon commented Oct 16, 2024

Fixes #1369

What changes did you make and why did you make them ?

  • Made the Google Drive URL required
  • Added validation for url to make sure it is a valid google drive link

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-10-16 at 11 31 14 AM
Visuals after changes are applied Screenshot 2024-10-16 at 11 29 09 AM Screenshot 2024-10-16 at 11 29 17 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-GoogleDriveValidation development
git pull https://github.com/nora-zajzon/VRMS.git GoogleDriveValidation

@nora-zajzon
Copy link
Member Author

Ignore the two test pushes. I was receiving help on git usage in Mondays meeting

@pluto-bell pluto-bell self-requested a review October 28, 2024 18:48
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work *~ Everything looks good to me and the Google Drive URL validation works as expected.

@pluto-bell pluto-bell added the ready for dev lead Add to issue when dev lead needs to take some action label Oct 28, 2024
@JackHaeg JackHaeg added ready for 2nd review When a PR is ready for another reviewer and removed ready for dev lead Add to issue when dev lead needs to take some action labels Mar 3, 2025
@kurtmgray kurtmgray self-requested a review March 10, 2025 23:10
Copy link
Member

@kurtmgray kurtmgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tested locally, and results are consistent with screenshots.

@kurtmgray kurtmgray merged commit 7cd87aa into hackforla:development Mar 11, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Form Validation - Google Drive URL

4 participants