Create redesigned "Users" page #1798
Create redesigned "Users" page #1798vorleakyek wants to merge 4 commits intohackforla:developmentfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Great work! MUI is being used for the buttons, the styling looks correct and the links work as expected (user permission search page to be added).
I noticed that the package.json, package-lock.json and yarn.lock files show updates, I don't know enough about back-end to say whether this would be an issue to merge or not, so I will leave this to the lead devs.
Edit: I'd love to hear from a lead dev on the above comment so I can know how to approach moving forward.
|
@pluto-bell, thanks for taking a look at the PR. I think you're right that the package.json, package-lock.json and yarn.lock files shouldn't be included in the PR. @trillium, is this okay? I tried to remove those files from the PR, but it's still showing this in the files changed. If not, what is the proper command to remove the files from PR? |
|
Per @trillium: restore the files using:
@trillium will plan to meet with @vorleakyek this week to restore the json files. |
fe36cf4 to
79c59f0
Compare
…d users-permission-search
79c59f0 to
ef5c3a0
Compare
ef5c3a0 to
29f1c9b
Compare
|
Thanks @trillium for helping me restore the JSON files yesterday. |
pluto-bell
left a comment
There was a problem hiding this comment.
Great, everything looks good to me and is working as expected (:
|
PR has been added to user_permissions_search feature branch! |

Fixes #1751
What changes did you make and why did you make them ?
/users/with links to/users/user-searchand/users/permission-searchas separate buttons.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied