Merged
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
pluto-bell
previously requested changes
Nov 19, 2024
Member
pluto-bell
left a comment
pluto-bell
left a comment
There was a problem hiding this comment.
Looks like everything is working with the new MUI components, great work on updating that.
I do want to point out that the design/styling has changed specifically under the "My Profile" section. I'd suggest we ensure the original design is intact with the new MUI components.
Before and After Screenshots
Before
After
trillium
approved these changes
Jan 16, 2025
Member
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
This PR is good, the changes are from default styling that we will address later. Thanks Evan!
trillium
dismissed
pluto-bell’s stale review
Visual changes are caused by MUI defaults changing the typography, we will adress this in a future issue
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1694
Switch HTML elements to Material UI