EventForm Refactor to Material UI#1844
Merged
trillium merged 15 commits intohackforla:developmentfrom Feb 11, 2025
Merged
Conversation
6 tasks
sasszz
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
trillium
reviewed
Feb 6, 2025
dannyprikaz
approved these changes
Feb 7, 2025
Member
dannyprikaz
left a comment
dannyprikaz
left a comment
There was a problem hiding this comment.
Looks good to me. As long as @trillium is good with the CSS solution, I approve.
Member
Author
|
if approved, i would like the opportunity to merge this pr, thank you! |
JackHaeg
added
the
ready for dev lead
Member
|
@trillium Please take a look at this when you have a moment (global styles) |
trillium
approved these changes
Feb 11, 2025
Member
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Great work, thanks!
Chatting on the Zoom call yesterday was helpful, I appreciate you mentioning that if we're overhauling styles, global styles are going to need to be revamped anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1699
What changes did you make and why did you make them ?
EventFormto use Material UI Form ComponentsScreenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied