1802 Gave superadmin admin privilages too#1856
Merged
trillium merged 7 commits intohackforla:developmentfrom Mar 25, 2025
Merged
1802 Gave superadmin admin privilages too#1856trillium merged 7 commits intohackforla:developmentfrom
trillium merged 7 commits intohackforla:developmentfrom
Conversation
JackHaeg
added
the
ready for dev lead
Member
|
@trillium Please review this PR when you have a moment. |
Member
|
Hi @trillium Can you please take a look at this PR when you have a moment? Once this PR is reviewed/merged, we can unblock releasing the User Permission Search feature to PROD. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jng34
previously requested changes
Mar 15, 2025
Member
jng34
left a comment
jng34
left a comment
There was a problem hiding this comment.
Aside from the parentheses needed in the logical statements, everything else looks good!
Member
trillium
approved these changes
Mar 25, 2025
Member
trillium
left a comment
trillium
left a comment
There was a problem hiding this comment.
Looking good to me, I double chcked if there were any other instances of admin that needed to be checked agaist superadmin too and didn't see any!
trillium
dismissed
jng34’s stale review
Looks like requested changes were resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1802
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website
Visuals before changes are applied
Visuals after changes are applied